Conversation
When pi cannot start, Emacs used to show little more than “Process exited.” The useful part of the failure was often printed by pi itself on stderr and then disappeared into the subprocess boundary. Show that stderr in the chat buffer for startup failures. A user who hits a #196-style proxy error now sees the actual invalid URL protocol message without needing to hunt through hidden process state or rerun pi outside Emacs. Keep the behavior intentionally small: - show stderr only when startup fails; - omit the stderr section when there is no stderr; - cap very large stderr while keeping the beginning and end; - do not add proxy-specific settings or try to parse stack traces. Refs #196. Checks: - make test SELECTOR=startup-error VERBOSE=1 - make test SELECTOR=stderr VERBOSE=1 - make test-core VERBOSE=1 - make test-integration-fake - make test-integration-ci-real SELECTOR=tool-contract - make check
dnouri
force-pushed
the
show-startup-stderr-errors
branch
from
bbace24 to
08a4a75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pi cannot start, Emacs used to show little more than “Process
exited.” The useful part of the failure was often printed by pi itself on
stderr and then disappeared into the subprocess boundary.
Show that stderr in the chat buffer for startup failures. A user who hits
a #196-style proxy error now sees the actual invalid URL protocol message
without needing to hunt through hidden process state or rerun pi outside
Emacs.
Keep the behavior intentionally small:
Refs #196.
Checks: