Fix docker-agent version for cli plugin & standalone exec#1802
Merged
gtardif merged 1 commit intodocker:mainfrom Feb 20, 2026
Merged
Fix docker-agent version for cli plugin & standalone exec#1802gtardif merged 1 commit intodocker:mainfrom
gtardif merged 1 commit intodocker:mainfrom
Conversation
There was a problem hiding this comment.
Review Summary
✅ No issues found - The code changes look good!
This PR correctly fixes the version command output for different execution modes:
- Standalone execution (
./bin/docker-agent version): Shows "docker-agent version dev" ✓ - Plugin mode (
docker agent version): Shows "docker agent version dev" ✓ - cagent mode (
./bin/cagent version): Shows "cagent version dev" ✓
The logic properly handles the command name construction by:
- Using the parent command's name when available (which is set to "agent" in plugin mode, "docker-agent" in standalone)
- Only prepending "docker " when running in plugin mode (
!plugin.RunningStandalone()) - This prevents duplicate prefixes and ensures correct output in all scenarios
The implementation is consistent with how the root command is configured in root.go (lines 102-115).
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
ddd0ba0 to
edf2a4f
Compare
dgageot
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another quick one to cleanup version output when executing docker-agent cli plugin (standalone or plugin mode)