Skip to content

Encode agent source URL when using it as agent name and key, so that it can be used properly in conversations when using serve api#2473

Merged
dgageot merged 1 commit intodocker:mainfrom
gtardif:agent_name_url_source
Apr 21, 2026
Merged

Encode agent source URL when using it as agent name and key, so that it can be used properly in conversations when using serve api#2473
dgageot merged 1 commit intodocker:mainfrom
gtardif:agent_name_url_source

Conversation

@gtardif
Copy link
Copy Markdown
Contributor

@gtardif gtardif commented Apr 21, 2026

No description provided.

@gtardif gtardif requested a review from a team as a code owner April 21, 2026 07:40
@gtardif gtardif force-pushed the agent_name_url_source branch 2 times, most recently from 3e455ff to f7d1013 Compare April 21, 2026 07:57
@gtardif
Copy link
Copy Markdown
Contributor Author

gtardif commented Apr 21, 2026

/review

Copy link
Copy Markdown

@docker-agent docker-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

This PR encodes URL-based agent source identifiers using url.PathEscape, which partially solves the serve api routing problem but has a correctness gap when URLs contain query strings.

Comment thread pkg/config/resolve.go Outdated
…it can be used properly in conversations when using `serve api`

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
@gtardif gtardif force-pushed the agent_name_url_source branch from f7d1013 to 71f508a Compare April 21, 2026 08:25
@gtardif
Copy link
Copy Markdown
Contributor Author

gtardif commented Apr 21, 2026

/review

Copy link
Copy Markdown

@docker-agent docker-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

Comment thread pkg/config/resolve.go
@dgageot dgageot merged commit 8c600d3 into docker:main Apr 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants