33073 migrate core web remaining #34178
Draft
+3,059
−3,467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary This commit refactors multiple services to replace the deprecated CoreWebService with Angular's HttpClient for making HTTP requests. The changes enhance code clarity and maintainability by utilizing Angular's built-in HTTP capabilities. ### Changes Made - Updated services to use HttpClient for GET, POST, PUT, and DELETE requests. - Replaced operator with for extracting response data. - Ensured all services maintain their original functionality while improving type safety and reducing boilerplate code. ### Impact This refactor improves the overall architecture by promoting the use of Angular's HttpClient, aligning with best practices for modern Angular development. ### Testing All affected services have been tested to ensure that they function correctly with the new implementation. ### Checklist - [x] Code compiles without errors - [x] Documentation updated - [x] Linting & formatting applied - [x] Ready for review
…ice and DotTemplatesService
…or improved clarity and maintainability
…with provideHttpClient and provideHttpClientTesting for improved clarity and maintainability
… HttpClient for improved clarity and maintainability
…Testing, removing deprecated HttpClientTestingModule for improved clarity and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots
This PR fixes: #33073