[SignalR] Allocate one StreamItemMessage per stream - #31660
Merged
Conversation
|
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
Member
|
Split the changes so we can API review just the relevant one. |
Member
Author
Member
|
I meant so I can merge this PR |
Member
Author
|
lol, fine, I'll open a different PR. |
BrennanConroy
force-pushed
the
brecon/streamalloc
branch
from
April 10, 2021 03:52
13058e9 to
d3ba6ab
Compare
davidfowl
reviewed
Apr 10, 2021
davidfowl
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate a single
StreamItemMessageper stream instead of per stream itemUnfortunately this does add a new API so will need to go to API review.