Address JS to DotNet byte[] Interop API Review Feedback - #34328
Conversation
| IJSStreamReference jsStreamReference, | ||
| long totalLength, | ||
| long maximumIncomingBytes, | ||
| long signalRMaximumIncomingBytes, |
There was a problem hiding this comment.
This change wasn't part of the API review, but I just felt this updated name could avoid future confusion (ex. clarifying it's not the max incoming bytes for the whole stream somehow).
There was a problem hiding this comment.
Great clarification. I probably would have thought it referred to the stream length before :)
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
I don't think I was in the review that must have covered it, so was the conclusion that we shouldn't expose configurability over the Pipe options because the defaults are always good? If so, I'm certainly happy about that. If the reasoning or goal is something different from that, please let me know because I'd love to fully understand.
Approving assuming this is the case :)
The defaults are reasonable, any configuration here isn't directly visible because the abstraction the user works with is a |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…3986) * Prototype Large File Upload Support Blazor * Blob.slice Implementation * Allow WASM to keep working * Update CircuitStreamingInterop.ts * PR Feedback * Cleanup * WASM * WebView * Webview Remove SendJSDataStream * Refactor Shared Streaming Interop Code TS * WebView DotNetObjectReference Based ReceiveData * BaseJSDataStream Refactor * E2E tests WASM * Unhandled Exception * ReceiveJSDataChunk using DotNet Object Reference for WASM/WebView * WASM Unmarshalled Interop Support * E2E tests * Update BaseJSDataStream.cs * PR Feedback * Update Web(View, Assembly) to match interop followup items * PR Feedback * Updated Release .js * Create Microsoft.JSInterop.WebAssembly.WarningSuppressions.xml * Updated WASM/WebView Pull Based Implementation * InputFile Updated Implementation * Cleanup * PR Feedback * Remove ReadRequest * PR Feedback II * Tests * PR Feedback * Address `JS` to `DotNet` byte[] Interop API Review Feedback (#34328) * Address `JS` to `DotNet` byte[] Interop API Review Feedback Fixes: #34327 * Update RemoteJSDataStreamTest.cs * Update JSRuntimeTest.cs * Final PR Feedback * Fix WebView for large Files
4 participants
Fixes: #34327