Skip to content

Don't show parameter name hints when they coincide with argument names - #14581

Merged
psfinaki merged 5 commits into
dotnet:mainfrom
psfinaki:psfinaki/hints-10
Jan 11, 2023
Merged

Don't show parameter name hints when they coincide with argument names#14581
psfinaki merged 5 commits into
dotnet:mainfrom
psfinaki:psfinaki/hints-10

Conversation

@psfinaki

@psfinaki psfinaki commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

closes #14447

When you have good argument and parameter names, you don't need hints.

image
@psfinaki
psfinaki requested a review from a team as a code owner January 10, 2023 14:10
@psfinaki

psfinaki commented Jan 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/azp run
@azure-pipelines

azure-pipelines Bot commented Jan 10, 2023

Copy link
Copy Markdown
Command 'rin' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.
@azure-pipelines

azure-pipelines Bot commented Jan 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).
@psfinaki

psfinaki commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

/azp run
@psfinaki
psfinaki enabled auto-merge (squash) January 10, 2023 18:58
@azure-pipelines

azure-pipelines Bot commented Jan 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).
@psfinaki

psfinaki commented Jan 11, 2023

Copy link
Copy Markdown
Contributor Author

/azp run
@azure-pipelines

azure-pipelines Bot commented Jan 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).
vzarytovskii
vzarytovskii reviewed Jan 11, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Hints/InlineParameterNameHints.fs Outdated
vzarytovskii
vzarytovskii reviewed Jan 11, 2023
View reviewed changes
Comment thread vsintegration/src/FSharp.Editor/Hints/InlineParameterNameHints.fs Outdated
vzarytovskii
vzarytovskii reviewed Jan 11, 2023
View reviewed changes
Comment thread vsintegration/tests/FSharp.Editor.Tests/Hints/HintTestFramework.fs Outdated
@psfinaki
psfinaki requested a review from vzarytovskii January 11, 2023 12:37
0101
0101 reviewed Jan 11, 2023
View reviewed changes
Comment thread vsintegration/tests/FSharp.Editor.Tests/Hints/HintTestFramework.fs Outdated
@psfinaki

psfinaki commented Jan 11, 2023

Copy link
Copy Markdown
Contributor Author

@vzarytovskii @0101 CI is green, please approve/reapprove
@psfinaki
psfinaki merged commit f7a1fd8 into dotnet:main Jan 11, 2023
@psfinaki
psfinaki deleted the psfinaki/hints-10 branch January 11, 2023 16:39
@allisonchou allisonchou mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/17.6

3 participants

@psfinaki @0101 @vzarytovskii