Add tuple tests to portable47 - #1702
Merged
Merged
Conversation
dsyme
reviewed
Nov 3, 2016
| <Compile Include="FSharp.Core\Microsoft.FSharp.Collections\Array2Module.fs" /> | ||
| <Compile Include="FSharp.Core\Microsoft.FSharp.Collections\Array3Module.fs" /> | ||
| <Compile Include="FSharp.Core\Microsoft.FSharp.Collections\Array4Module.fs" /> | ||
| <Compile Include="FSharp.Core\Microsoft.FSharp.Collections\ArrayProperties.fs" Condition=" '$(TargetFramework)' != 'portable47' " /> |
dsyme
reviewed
Nov 3, 2016
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="LibraryTestFx.fs" /> | ||
| <Compile Include="FSharp.Core\Microsoft.FSharp.Collections\Utils.fs" Condition=" '$(TargetFramework)' != 'portable47' " /> |
Contributor
|
Looks good |
dsyme
reviewed
Nov 4, 2016
| <Reference Include="System.ValueTuple"> | ||
| <HintPath Condition=" '$(TargetFramework)' == 'coreclr' ">..\..\..\packages\System.ValueTuple.4.0.0-rc3-24212-01\lib\netstandard1.1\System.ValueTuple.dll</HintPath> | ||
| <HintPath Condition=" '$(TargetFramework)' != 'coreclr' ">..\..\..\packages\System.ValueTuple.4.4.0-beta-24631-01\lib\netstandard1.0\System.ValueTuple.dll</HintPath> | ||
| <HintPath Condition=" '$(TargetFramework)' == 'profile47' ">..\..\..\packages\System.ValueTuple.4.4.0-beta-24631-01\lib\netstandard1.0\System.ValueTuple.dll</HintPath> |
Contributor
There was a problem hiding this comment.
Why all these different versions? Why not just one version?
added 3 commits
November 4, 2016 00:14
This reverts commit bf80d4e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a tuple dll that supports portable47, enable the tuple tests in core unit tests for the profile47 version of fsharp.core.dll