Skip to content

Fixed typo for calibrators - #6438

Merged
michaelgsharp merged 2 commits into
dotnet:mainfrom
KKghub:kk-typo-fix
Nov 17, 2022
Merged

Fixed typo for calibrators#6438
michaelgsharp merged 2 commits into
dotnet:mainfrom
KKghub:kk-typo-fix

Conversation

@KKghub

@KKghub KKghub commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Fixes #6210

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.
@codecov

codecov Bot commented Nov 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6438 (9fb181e) into main (87337c0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6438   +/-   ##
=======================================
  Coverage   68.55%   68.55%           
=======================================
  Files        1170     1170           
  Lines      246977   246977           
  Branches    25792    25792           
=======================================
  Hits       169303   169303           
  Misses      70951    70951           
  Partials     6723     6723           
Flag Coverage Δ
Debug 68.55% <ø> (ø)
production 62.95% <ø> (ø)
test 88.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.Data/TrainCatalog.cs 82.70% <ø> (ø)
src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs 79.50% <0.00%> (-0.28%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 26.90% <0.00%> (+1.01%) ⬆️

@michaelgsharp michaelgsharp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelgsharp
michaelgsharp merged commit 0379e01 into dotnet:main Nov 17, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants