Skip to content

Fix DataFrame ToString() method to use correct alignment for columns to produce readable output - #6673

Merged
michaelgsharp merged 1 commit into
dotnet:mainfrom
asmirnov82:6672_fix_dataframe_to_string
May 11, 2023
Merged

Fix DataFrame ToString() method to use correct alignment for columns to produce readable output#6673
michaelgsharp merged 1 commit into
dotnet:mainfrom
asmirnov82:6672_fix_dataframe_to_string

Conversation

@asmirnov82

Copy link
Copy Markdown
Contributor

fixes #6672

@michaelgsharp

Copy link
Copy Markdown
Contributor

@asmirnov82 looks good to me. Thanks for submitting this!

@codecov

codecov Bot commented May 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6673 (9c3e59a) into main (3d705bf) will increase coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6673      +/-   ##
==========================================
+ Coverage   68.67%   68.76%   +0.09%     
==========================================
  Files        1203     1215      +12     
  Lines      250974   251524     +550     
  Branches    26209    26227      +18     
==========================================
+ Hits       172350   172966     +616     
+ Misses      71800    71744      -56     
+ Partials     6824     6814      -10     
Flag Coverage Δ
Debug 68.76% <0.00%> (+0.09%) ⬆️
production 63.28% <0.00%> (+0.11%) ⬆️
test 88.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.cs 86.45% <0.00%> (-0.23%) ⬇️

... and 36 files with indirect coverage changes

@michaelgsharp
michaelgsharp merged commit de9e468 into dotnet:main May 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2023
@asmirnov82
asmirnov82 deleted the 6672_fix_dataframe_to_string branch June 22, 2023 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants