Modernized some argument checks that still used string literals for parameter names - #6766
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6766 +/- ##
==========================================
+ Coverage 68.88% 68.91% +0.03%
==========================================
Files 1216 1216
Lines 251137 251401 +264
Branches 26269 26322 +53
==========================================
+ Hits 172997 173265 +268
+ Misses 71313 71270 -43
- Partials 6827 6866 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
@LittleLittleCloud , @michaelgsharp , @JakeRadMSFT , any plans to merge this? It's a quick and easy way to improve the codebase |
LittleLittleCloud
approved these changes
Aug 7, 2023
Member
|
LGTM, thanks for the contribution |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes in behavior, just leveraging more modern syntax