Skip to content

Fix inconsistent null handling in DataFrame Arithmetics - #6770

Merged
michaelgsharp merged 5 commits into
dotnet:mainfrom
asmirnov82:5650_inconsistent_null_handling_dataframe_arithmetic
Aug 31, 2023
Merged

Fix inconsistent null handling in DataFrame Arithmetics#6770
michaelgsharp merged 5 commits into
dotnet:mainfrom
asmirnov82:5650_inconsistent_null_handling_dataframe_arithmetic

Conversation

@asmirnov82

Copy link
Copy Markdown
Contributor

Fixes #5650

@codecov

codecov Bot commented Jul 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6770 (99bbe5d) into main (39235a7) will decrease coverage by 0.06%.
The diff coverage is 50.82%.

@@            Coverage Diff             @@
##             main    #6770      +/-   ##
==========================================
- Coverage   69.03%   68.97%   -0.06%     
==========================================
  Files        1237     1237              
  Lines      252700   253459     +759     
  Branches    26446    26536      +90     
==========================================
+ Hits       174449   174825     +376     
- Misses      71308    71683     +375     
- Partials     6943     6951       +8     
Flag Coverage Δ
Debug 68.97% <50.82%> (-0.06%) ⬇️
production 63.54% <48.39%> (-0.07%) ⬇️
test 88.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs 48.27%
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs 100.00%
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 100.00%
Comment thread src/Microsoft.Data.Analysis/PrimitiveDataFrameColumnArithmetic.cs
@asmirnov82

Copy link
Copy Markdown
Contributor Author

Hello @JakeRadMSFT ,
conflict that prevented this PR from being merged into dev is solved now. Could you please perform a merge?

@michaelgsharp

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).
@michaelgsharp
michaelgsharp merged commit e6a88c4 into dotnet:main Aug 31, 2023
@asmirnov82
asmirnov82 deleted the 5650_inconsistent_null_handling_dataframe_arithmetic branch August 31, 2023 17:34
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants