Skip to content

File-scoped namespaces in files under ComponentModel (Microsoft.ML.Core) - #6788

Merged
michaelgsharp merged 2 commits into
dotnet:mainfrom
Lehonti:improvement2
Aug 31, 2023
Merged

File-scoped namespaces in files under ComponentModel (Microsoft.ML.Core)#6788
michaelgsharp merged 2 commits into
dotnet:mainfrom
Lehonti:improvement2

Conversation

@Lehonti

@Lehonti Lehonti commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@michaelgsharp

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).
@codecov

codecov Bot commented Aug 25, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6788 (b83b18b) into main (39235a7) will increase coverage by 0.01%.
The diff coverage is 71.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6788      +/-   ##
==========================================
+ Coverage   69.03%   69.04%   +0.01%     
==========================================
  Files        1237     1237              
  Lines      252700   252700              
  Branches    26446    26446              
==========================================
+ Hits       174449   174478      +29     
+ Misses      71308    71283      -25     
+ Partials     6943     6939       -4     
Flag Coverage Δ
Debug 69.04% <71.32%> (+0.01%) ⬆️
production 63.62% <71.32%> (+0.01%) ⬆️
test 88.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...oft.ML.Core/ComponentModel/AssemblyLoadingUtils.cs 68.67% <68.96%> (ø)
...crosoft.ML.Core/ComponentModel/ComponentFactory.cs 75.00% <70.00%> (ø)
...crosoft.ML.Core/ComponentModel/ComponentCatalog.cs 70.24% <70.14%> (ø)
...t.ML.Core/ComponentModel/LoadableClassAttribute.cs 80.64% <83.11%> (ø)
...t.ML.Core/ComponentModel/ExtensionBaseAttribute.cs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@michaelgsharp
michaelgsharp merged commit 34389b6 into dotnet:main Aug 31, 2023
@Lehonti
Lehonti deleted the improvement2 branch August 31, 2023 07:28
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants