Skip to content

Implement vectorized binary arithmetic operations - #6854

Merged
JakeRadMSFT merged 5 commits into
dotnet:mainfrom
asmirnov82:5695_vectorize_arithmetic_operations
Oct 16, 2023
Merged

Implement vectorized binary arithmetic operations#6854
JakeRadMSFT merged 5 commits into
dotnet:mainfrom
asmirnov82:5695_vectorize_arithmetic_operations

Conversation

@asmirnov82

@asmirnov82 asmirnov82 commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Part of #5695

Implement vectorized binary arithmetic operations, align internal Arithmetic API with the latest Tensor.Numeric API

@asmirnov82

Copy link
Copy Markdown
Contributor Author

@JakeRadMSFT could you please take a look?

Comment thread src/Microsoft.Data.Analysis/Computations/Arithmetic.cs
@codecov

codecov Bot commented Oct 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6854 (5cf12a0) into main (64d7ebd) will decrease coverage by 0.25%.
The diff coverage is 73.17%.

@@            Coverage Diff             @@
##             main    #6854      +/-   ##
==========================================
- Coverage   69.63%   69.39%   -0.25%     
==========================================
  Files        1237     1238       +1     
  Lines      247617   249429    +1812     
  Branches    25436    25528      +92     
==========================================
+ Hits       172429   173090     +661     
- Misses      68577    69715    +1138     
- Partials     6611     6624      +13     
Flag Coverage Δ
Debug 69.39% <73.17%> (-0.25%) ⬇️
production 63.92% <70.96%> (-0.27%) ⬇️
test 88.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Microsoft.Data.Analysis/BitUtility.cs 84.78% <100.00%> (-0.64%) ⬇️
...icrosoft.Data.Analysis/Computations/Arithmetics.cs 44.84% <ø> (ø)
...lysis/PrimitiveColumnContainer.BinaryOperations.cs 100.00% <100.00%> (ø)
...FrameColumn.BinaryOperationAPIs.ExplodedColumns.cs 7.69% <ø> (ø)
...eColumn.BinaryOperationImplementations.Exploded.cs 76.47% <ø> (ø)
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 73.07% <ø> (-0.37%) ⬇️
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.32% <100.00%> (+<0.01%) ⬆️
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 57.06% <76.19%> (ø)
...Microsoft.Data.Analysis/Computations/Arithmetic.cs 62.06% <62.06%> (ø)

... and 11 files with indirect coverage changes

@JakeRadMSFT
JakeRadMSFT merged commit f7b8d56 into dotnet:main Oct 16, 2023
@asmirnov82
asmirnov82 deleted the 5695_vectorize_arithmetic_operations branch October 16, 2023 22:16
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants