Tweak CreateByModelNameAsync - #7015
Merged
Merged
Conversation
- Add a CancellationToken to CreateByModelNameAsync, allowing the download and parsing to be canceled. - Use ReadLineAsync(cancellationToken), which not only allows it to be canceled, but avoids ~100K task allocations - Fix Helpers.FromBase64String to support lines longer than 300 chars
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7015 +/- ##
==========================================
- Coverage 68.81% 68.80% -0.01%
==========================================
Files 1258 1258
Lines 250643 250662 +19
Branches 25606 25612 +6
==========================================
- Hits 172479 172474 -5
- Misses 71540 71555 +15
- Partials 6624 6633 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tarekgh
approved these changes
Feb 20, 2024
tarekgh
left a comment
tarekgh
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @tarekgh