Skip to content

Make MlImage tests not block file for reading - #7029

Merged
michaelgsharp merged 1 commit into
dotnet:mainfrom
michaelgsharp:ml-image-tests
Feb 27, 2024
Merged

Make MlImage tests not block file for reading#7029
michaelgsharp merged 1 commit into
dotnet:mainfrom
michaelgsharp:ml-image-tests

Conversation

@michaelgsharp

Copy link
Copy Markdown
Contributor

Makes ML-Image tests not block the image file for reading as this is causing some test failures.

@michaelgsharp

Copy link
Copy Markdown
Contributor Author

@tarekgh Is there a reason we make the image file on disk not be able to be read share opened?

@michaelgsharp

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).
@codecov

codecov Bot commented Feb 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (d0aa2c2) to head (d6cbcdb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7029   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files        1254     1254           
  Lines      250204   250204           
  Branches    25529    25529           
=======================================
+ Hits       172127   172132    +5     
+ Misses      71467    71464    -3     
+ Partials     6610     6608    -2     
Flag Coverage Δ
Debug 68.79% <100.00%> (+<0.01%) ⬆️
production 63.22% <ø> (+<0.01%) ⬆️
test 88.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/Microsoft.ML.Tests/ImagesTests.cs 91.79% <100.00%> (ø)

... and 2 files with indirect coverage changes

@michaelgsharp
michaelgsharp merged commit 3855dca into dotnet:main Feb 27, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2024
@michaelgsharp
michaelgsharp deleted the ml-image-tests branch November 18, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants