Skip to content

Update version for 5.0 - #7311

Merged
ericstj merged 1 commit into
dotnet:mainfrom
ericstj:version5
Nov 18, 2024
Merged

Update version for 5.0#7311
ericstj merged 1 commit into
dotnet:mainfrom
ericstj:version5

Conversation

@ericstj

@ericstj ericstj commented Nov 14, 2024

Copy link
Copy Markdown
Member

No description provided.

Comment thread eng/BranchInfo.props
<PropertyGroup Condition="'$(IsStableProject)' != 'true'">
<MajorVersion>0</MajorVersion>
<MinorVersion>22</MinorVersion>
<MinorVersion>23</MinorVersion>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23

can this get generated from year number? just thought :-)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I could calculate it from the stable product version. That would be more refactoring than I wanted to do.

@codecov

codecov Bot commented Nov 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (5090327) to head (3b21c68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7311   +/-   ##
=======================================
  Coverage   68.87%   68.88%           
=======================================
  Files        1470     1470           
  Lines      274005   274005           
  Branches    28403    28403           
=======================================
+ Hits       188717   188736   +19     
+ Misses      77970    77949   -21     
- Partials     7318     7320    +2     
Flag Coverage Δ
Debug 68.88% <ø> (+<0.01%) ⬆️
production 63.29% <ø> (+<0.01%) ⬆️
test 89.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

---- 🚨 Try these New Features:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants