Skip to content

Fix DateTime export to csv with culture info - #7358

Merged
michaelgsharp merged 1 commit into
dotnet:mainfrom
asmirnov82:7333_dataframe_savecsv_cultureinfo
Jan 13, 2025
Merged

Fix DateTime export to csv with culture info#7358
michaelgsharp merged 1 commit into
dotnet:mainfrom
asmirnov82:7333_dataframe_savecsv_cultureinfo

Conversation

@asmirnov82

Copy link
Copy Markdown
Contributor

Fixes #7333

@codecov

codecov Bot commented Jan 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (886e2ff) to head (5cea57c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7358   +/-   ##
=======================================
  Coverage   68.88%   68.89%           
=======================================
  Files        1473     1473           
  Lines      270771   270814   +43     
  Branches    27884    27884           
=======================================
+ Hits       186529   186567   +38     
- Misses      76970    76976    +6     
+ Partials     7272     7271    -1     
Flag Coverage Δ
Debug 68.89% <100.00%> (+<0.01%) ⬆️
production 63.20% <100.00%> (-0.01%) ⬇️
test 89.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.IO.cs 83.57% <100.00%> (+0.06%) ⬆️
...Microsoft.Data.Analysis.Tests/DataFrame.IOTests.cs 99.17% <100.00%> (+0.02%) ⬆️

... and 5 files with indirect coverage changes

@michaelgsharp
michaelgsharp merged commit 1f5a81b into dotnet:main Jan 13, 2025
@asmirnov82
asmirnov82 deleted the 7333_dataframe_savecsv_cultureinfo branch January 13, 2025 19:06
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants