update cmake mac - #7443
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7443 +/- ##
==========================================
- Coverage 69.00% 69.00% -0.01%
==========================================
Files 1482 1482
Lines 273876 273876
Branches 28254 28254
==========================================
- Hits 188979 188975 -4
- Misses 77514 77516 +2
- Partials 7383 7385 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ericstj
reviewed
Apr 21, 2025
ericstj
approved these changes
Apr 21, 2025
ericstj
left a comment
ericstj
left a comment
Member
There was a problem hiding this comment.
It seems like this resolves the error.
ericstj
marked this pull request as ready for review
April 21, 2025 19:29
Member
|
Change fixed the install step, but build was failing in the same way. I updated |
Contributor
Author
|
/ba-g test failure is a known issue. |
ericstj
added a commit
that referenced
this pull request
May 21, 2025
* update cmake mac * cmake specific version * remove specific version * cmake policy version minimum * Update build/ci/job-template.yml * Try adding -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to libomp.rb * Update job-template.yml * Update cmake_minimum_required --------- Co-authored-by: Eric StJohn <ericstj@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.