Support Tiktoken Gpt-4.1 Model - #7453
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new "gpt-4.1" model in the Tiktoken tokenizer, addressing issue #7450.
- Added test cases for "gpt-4.1" and "gpt-4.1-mini" in the test suite.
- Updated model prefix mappings in the tokenizer to support both dashed and non-dashed "gpt-4.1" formats.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Microsoft.ML.Tokenizers.Tests/TiktokenTests.cs | Added inline test data for "gpt-4.1" variants to validate encoding support. |
| src/Microsoft.ML.Tokenizers/Model/TiktokenTokenizer.cs | Inserted new mappings for "gpt-4.1-" and "gpt-4.1" models, mapping them to ModelEncoding.O200kBase. |
Member
Author
stephentoub
reviewed
May 2, 2025
stephentoub
approved these changes
May 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7453 +/- ##
==========================================
- Coverage 69.00% 68.99% -0.02%
==========================================
Files 1483 1482 -1
Lines 274563 273879 -684
Branches 28395 28254 -141
==========================================
- Hits 189455 188955 -500
+ Misses 77672 77537 -135
+ Partials 7436 7387 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7450