Conversation
dotnet-policy-service
Bot
added
community ✨
ghost
marked this pull request as ready for review
April 25, 2025 14:13
ghost
self-requested a review
as a code owner
April 25, 2025 14:13
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy workaround for handling Mac Catalyst full-screen mode in the ScrollView UI tests. The changes aim to improve screenshot consistency by eliminating the conditional full-screen mode code.
- Removed conditional full-screen mode adjustments in three test methods.
- Ensured tests now rely on the updated screenshot capture mechanism.
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/ScrollViewUITests.cs:24
- Ensure that the removal of the full-screen workaround is fully validated by updated CI screenshots, as the tests now rely on the updated screenshot mechanism to maintain consistent dimensions.
#if MACCATALYST
ghost
added
the
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
May 8, 2025
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…and image cropping issue (dotnet#29204) * removed EnterFullScreen workaround for ScrollViewUITests * Updated mac images from CI * Update SwitchOnOffVisualStatesTest_SwitchOn.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the previous workaround for handling Mac Catalyst screenshots in full-screen mode, as the underlying screenshot capture mechanism has been improved.
Issue
Screenshot verification tests for Mac Catalyst were inconsistent due to some test cases running in full-screen mode while others didn't. This was happening because:
App.EnterFullScreenwas called in one of the ScrollView test cases.Solution