[HouseKeeping] Fix inconsistant namespace in HostApp - #35210
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35210Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35210" |
There was a problem hiding this comment.
Pull request overview
This PR standardizes the namespace declarations for a handful of Appium issue tests in TestCases.Shared.Tests so they align with the rest of the issue-test suite’s namespace layout.
Changes:
- Update
Issue33227to useMicrosoft.Maui.TestCases.Tests.Issuesinstead ofMaui.Controls.TestCases.Tests.Issues. - Fix two issue tests that were under the duplicated namespace segment
...Tests.Tests.Issues. - Fix a singular/plural mismatch (
Issue->Issues) for an issue test namespace.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33227.cs | Renames namespace to the standard Microsoft.Maui.TestCases.Tests.Issues. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29588.cs | Removes duplicated Tests.Tests segment from namespace. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28968.cs | Removes duplicated Tests.Tests segment from namespace. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22075.cs | Fixes namespace pluralization (Issue -> Issues). |
| using UITest.Core; | ||
|
|
||
| namespace Maui.Controls.TestCases.Tests.Issues; | ||
| namespace Microsoft.Maui.TestCases.Tests.Issues; |
There was a problem hiding this comment.
PR title/description mention fixing namespaces in the HostApp, but this change is in TestCases.Shared.Tests (Appium test project). Please update the PR title/description to reflect the actual scope (tests project), and consider fixing the spelling of “inconsistant” -> “inconsistent”.
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Description of Change <!-- Enter description of the fix in this section --> This pull request standardizes the namespace declarations for several test case files related to issues in the test suite. The changes ensure that all files use the correct `Microsoft.Maui.TestCases.Tests.Issues` namespace, improving consistency and maintainability. **Namespace corrections:** * Changed the namespace in `Issue22075.cs` from `Microsoft.Maui.TestCases.Tests.Issue` to `Microsoft.Maui.TestCases.Tests.Issues` to match the naming convention. * Updated the namespace in `Issue28968.cs` from `Microsoft.Maui.TestCases.Tests.Tests.Issues` to `Microsoft.Maui.TestCases.Tests.Issues`. * Updated the namespace in `Issue29588.cs` from `Microsoft.Maui.TestCases.Tests.Tests.Issues` to `Microsoft.Maui.TestCases.Tests.Issues`. * Changed the namespace in `Issue33227.cs` from `Maui.Controls.TestCases.Tests.Issues` to `Microsoft.Maui.TestCases.Tests.Issues`.
Description of Change
This pull request standardizes the namespace declarations for several test case files related to issues in the test suite. The changes ensure that all files use the correct
Microsoft.Maui.TestCases.Tests.Issuesnamespace, improving consistency and maintainability.Namespace corrections:
Issue22075.csfromMicrosoft.Maui.TestCases.Tests.IssuetoMicrosoft.Maui.TestCases.Tests.Issuesto match the naming convention.Issue28968.csfromMicrosoft.Maui.TestCases.Tests.Tests.IssuestoMicrosoft.Maui.TestCases.Tests.Issues.Issue29588.csfromMicrosoft.Maui.TestCases.Tests.Tests.IssuestoMicrosoft.Maui.TestCases.Tests.Issues.Issue33227.csfromMaui.Controls.TestCases.Tests.IssuestoMicrosoft.Maui.TestCases.Tests.Issues.