[Testing] Replace retryDelay with retryTimeout in UI tests - #35367
Merged
kubaflo merged 1 commit intoMay 10, 2026
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35367Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35367" |
Replace retryDelay with retryTimeout in Issue18751 and Issue18896 UI tests. - Issue18751: retryDelay→retryTimeout + CollectionView timing comment - Issue18896: retryDelay→retryTimeout (2s→3s) + ListView timing comment Supersedes #33809. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubaflo
force-pushed
the
fix/replace-retrydelay-with-retrytimeout
branch
from
May 10, 2026 21:46
56350b0 to
d84e4da
Compare
PureWeen
pushed a commit
that referenced
this pull request
Jun 2, 2026
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! Replaces `retryDelay` with `retryTimeout` in 2 UI test files. This is a clean replacement for PR #33809, which had merge conflicts because most of its changes were already applied. ### Changes | File | Change | |------|--------| | Issue18751 | `retryDelay`→`retryTimeout` + CollectionView timing comment | | Issue18896 | `retryDelay`→`retryTimeout` (2s→3s) + ListView timing comment | ### Context The original PR #33809 applied Copilot code review suggestions from #33749 to replace `Thread.Sleep`/`Task.Delay` with `retryTimeout` across 9 files. 7 of those changes were already merged, leaving only these 2 files with the stale `retryDelay` parameter. Supersedes #33809. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Replaces
retryDelaywithretryTimeoutin 2 UI test files. This is a clean replacement for PR #33809, which had merge conflicts because most of its changes were already applied.Changes
retryDelay→retryTimeout+ CollectionView timing commentretryDelay→retryTimeout(2s→3s) + ListView timing commentContext
The original PR #33809 applied Copilot code review suggestions from #33749 to replace
Thread.Sleep/Task.DelaywithretryTimeoutacross 9 files. 7 of those changes were already merged, leaving only these 2 files with the staleretryDelayparameter.Supersedes #33809.