Reduce boolean boxes across the framework - #35596
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35596Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35596" |
Contributor
|
Hey there @@pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
github-actions
Bot
added
area-controls-general
Collaborator
|
/review -b feature/refactor-copilot-yml |
MauiBot
reviewed
May 24, 2026
MauiBot
left a comment
MauiBot
left a comment
Collaborator
There was a problem hiding this comment.
Expert Review — 1 findings
See inline comments for details.
| global using Microsoft.Maui; | ||
| global using Microsoft.Maui.Handlers; | ||
| global using Microsoft.Maui.Platform; | ||
| global using Microsoft.Maui.Controls.Internals; |
Collaborator
There was a problem hiding this comment.
[critical] Platform-Specific Code Scoping / Build - Adding Microsoft.Maui.Controls.Internals as a global using imports every internal Controls type into every file in this project. On iOS files that also use Foundation and unqualified [Preserve], this makes PreserveAttribute ambiguous between Foundation.PreserveAttribute and Microsoft.Maui.Controls.Internals.PreserveAttribute, causing the iOS build to fail. Please keep BooleanBoxes references explicit, use a targeted alias/static using, or add local usings only where needed instead of globally importing the whole Internals namespace.
MauiBot
added
s/agent-review-incomplete
s/agent-fix-win
Collaborator
|
/review -b feature/refactor-copilot-yml |
MauiBot
reviewed
May 24, 2026
MauiBot
left a comment
MauiBot
left a comment
Collaborator
There was a problem hiding this comment.
Expert Review — 1 findings
See inline comments for details.
This was referenced May 25, 2026
Collaborator
|
/review -b feature/refactor-copilot-yml |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This was referenced May 26, 2026
Contributor
Author
|
I don't think the bot suggestion makes sense. I believe to have one API is better |
…ols.Core Replace raw true/false literals with BooleanBoxes.TrueBox/FalseBox in SetValue and SetValueFromRenderer calls for bool-typed BindableProperties. Added using Microsoft.Maui.Controls.Internals to ShellPageRendererTracker.cs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ties in Controls.Core Replace raw true/false/default(bool) literals with BooleanBoxes.TrueBox/FalseBox in BindableProperty.CreateAttached and CreateAttachedReadOnly calls for bool-typed properties. Added using Microsoft.Maui.Controls.Internals to 6 files that did not already have it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… Controls.Core Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…cator The global using Microsoft.Maui.Controls.Internals caused CS0104 ambiguous reference errors for PreserveAttribute in iOS files that also import Foundation. Remove the global using and add an explicit using to the one file that was missing it (ActivityIndicator.cs). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…boxing All public bool property setters that previously called SetValue(Prop, value) now call SetValue(Prop, BooleanBoxes.Box(value)) to eliminate per-assignment heap allocations. This completes the boxing optimization across: - VisualElement (IsVisible, IsEnabled, InputTransparent, IsFocused) - CheckBox, Switch, RadioButton (IsChecked, IsToggled) - ActivityIndicator, RefreshView, ListView, CarouselView, and others - SetterSpecificity overloads (FromHandler) also updated Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add BooleanBoxesProductionTests class with Assert.Same checks on: * DefaultValue for representative BindableProperties * GetValue() after setter calls (verifies cached box is stored) - Fix CoerceIsEnabledProperty and CoerceInputTransparentProperty in VisualElement to return BooleanBoxes.Box(...) / BooleanBoxes.FalseBox instead of raw bool literals (which would allocate a new box) - Fix CoerceIsEnabledProperty in MenuItem similarly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pictos
force-pushed
the
pj/avoid-bool-boxing
branch
from
June 14, 2026 02:14
63cd5ab to
f0dbf63
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Jun 14, 2026
PureWeen
pushed a commit
that referenced
this pull request
Jun 22, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Description of Change <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
kubaflo
pushed a commit
that referenced
this pull request
Jun 25, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Description of Change <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
kubaflo
pushed a commit
that referenced
this pull request
Jul 3, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Description of Change <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
kubaflo
pushed a commit
that referenced
this pull request
Jul 6, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
devanathan-vaithiyanathan
pushed a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jul 7, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> <!-- Enter description of the fix in this section --> This is a follow up from dotnet#35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with dotnet#35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
PureWeen
pushed a commit
that referenced
this pull request
Jul 7, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
PureWeen
pushed a commit
that referenced
this pull request
Jul 7, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
devanathan-vaithiyanathan
pushed a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jul 8, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> <!-- Enter description of the fix in this section --> This is a follow up from dotnet#35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with dotnet#35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
kubaflo
pushed a commit
that referenced
this pull request
Jul 10, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
kubaflo
pushed a commit
that referenced
this pull request
Jul 15, 2026
<!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> <!-- Enter description of the fix in this section --> This is a follow up from #35303, that implements the `BooleanBoxes` class and use inside the `Control` project [Use the same solution that the WPF team uses](https://github.com/dotnet/wpf/blob/b325a186ebcead7fddfde43c118f6a807397de35/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/KnownBoxes.cs#L10), cache the boxed `true` and `false` values, and use it instead of boxing a new boolean on every operation. <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Relates with #35302 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus@Pedros-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a follow up from #35303, that implements the
BooleanBoxesclass and use inside theControlprojectUse the same solution that the WPF team uses, cache the boxed
trueandfalsevalues, and use it instead of boxing a new boolean on every operation.Issues Fixed
Relates with #35302