Skip to content

Remove MAUI compatibility package #35870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
Jun 24, 2026
Merged

Remove MAUI compatibility package #35870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e52bea
Remove MAUI compatibility package
jfversluis Jun 11, 2026
a98683a
Remove skill name from verification eval prompts
jfversluis Jun 12, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .github/scripts/RunTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ $UnitTestProjects = [ordered]@{
"Essentials" = "src/Essentials/test/UnitTests/Essentials.UnitTests.csproj"
"Graphics" = "src/Graphics/tests/Graphics.Tests/Graphics.Tests.csproj"
"Resizetizer" = "src/SingleProject/Resizetizer/test/UnitTests/Resizetizer.UnitTests.csproj"
"Compatibility" = "src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj"
"DualScreen" = "src/Controls/Foldable/test/Controls.DualScreen.UnitTests.csproj"
"AI" = "src/AI/tests/Essentials.AI.UnitTests/Essentials.AI.UnitTests.csproj"
}
Expand Down
2 changes: 0 additions & 2 deletions .github/scripts/shared/Detect-TestsInDiff.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ $UnitTestProjects = @{
"Essentials.UnitTests" = "src/Essentials/test/UnitTests/"
"Graphics.Tests" = "src/Graphics/tests/Graphics.Tests/"
"Resizetizer.UnitTests" = "src/SingleProject/Resizetizer/test/UnitTests/"
"Compatibility.Core.UnitTests" = "src/Compatibility/Core/tests/Compatibility.UnitTests/"
"Essentials.AI.UnitTests" = "src/AI/tests/Essentials.AI.UnitTests/"
}

Expand All @@ -122,7 +121,6 @@ $UnitTestProjectPaths = @{
"Essentials.UnitTests" = "src/Essentials/test/UnitTests/Essentials.UnitTests.csproj"
"Graphics.Tests" = "src/Graphics/tests/Graphics.Tests/Graphics.Tests.csproj"
"Resizetizer.UnitTests" = "src/SingleProject/Resizetizer/test/UnitTests/Resizetizer.UnitTests.csproj"
"Compatibility.Core.UnitTests" = "src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj"
"Essentials.AI.UnitTests" = "src/AI/tests/Essentials.AI.UnitTests/Essentials.AI.UnitTests.csproj"
}

Expand Down
1 change: 0 additions & 1 deletion .github/skills/verify-tests-fail-without-fix/scripts/verify-tests-fail.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ $script:UnitTestProjectMap = @{
"Essentials.UnitTests" = "src/Essentials/test/UnitTests/Essentials.UnitTests.csproj"
"Graphics.Tests" = "src/Graphics/tests/Graphics.Tests/Graphics.Tests.csproj"
"Resizetizer.UnitTests" = "src/SingleProject/Resizetizer/test/UnitTests/Resizetizer.UnitTests.csproj"
"Compatibility.Core.UnitTests" = "src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj"
"Essentials.AI.UnitTests" = "src/AI/tests/Essentials.AI.UnitTests/Essentials.AI.UnitTests.csproj"
}

Expand Down
6 changes: 3 additions & 3 deletions .github/skills/verify-tests-fail-without-fix/tests/eval.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ scenarios:

- name: "Regression: tests passing without fix means verification FAILED"
prompt: |
We ran the verify-tests-fail-without-fix skill on PR #77123. The test was
We ran the test verification workflow on PR #77123. The test was
run without the fix applied, and it PASSED.

What does this result mean? Is the verification successful?
Expand All @@ -83,7 +83,7 @@ scenarios:

- name: "Edge case: no test files detected in the PR"
prompt: |
Run verify-tests-fail-without-fix on this PR. The PR only contains a fix
Run test verification on this PR. The PR only contains a fix
in src/Controls/src/Core/Handlers/Entry/EntryHandler.Android.cs but no
test files were added.

Expand Down Expand Up @@ -136,7 +136,7 @@ scenarios:

- name: "Regression: agent correctly reports test failure as verification success"
prompt: |
I just ran verify-tests-fail-without-fix on PR #44444. The test FAILED with an
I just ran the test verification workflow on PR #44444. The test FAILED with an
assertion error: Assert.That(rect.Height, Is.GreaterThan(0)) failed — the element
rendered with zero height. This is failure-only verification (no fix files).
What should I report?
Expand Down
3 changes: 0 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@
<IncludeAndroidTargetFrameworks>true</IncludeAndroidTargetFrameworks>
<IncludeMacCatalystTargetFrameworks>true</IncludeMacCatalystTargetFrameworks>
<IncludeIosTargetFrameworks>true</IncludeIosTargetFrameworks>
<IncludeCompatibilityProjects>false</IncludeCompatibilityProjects>
<IncludeCompatibilityProjects Condition="'$(SolutionFileName)' == 'Microsoft.Maui.sln'">true</IncludeCompatibilityProjects>
</PropertyGroup>

<!-- this is CI, so everything should be there -->
Expand All @@ -130,7 +128,6 @@

<PropertyGroup>
<DefineConstants Condition="'$(_MauiTargetPlatformIsWindows)' == 'True'">$(DefineConstants);WINDOWS</DefineConstants>
<DefineConstants Condition="'$(IncludeCompatibilityProjects)' == 'True'">$(DefineConstants);COMPATIBILITY_ENABLED</DefineConstants>
<DefineConstants Condition="'$(IncludePreviousTfms)' == 'True'">$(DefineConstants);ENABLE_PREVIOUS_TFM_BUILDS</DefineConstants>
<!-- <SymbolPackageFormat>snupkg</SymbolPackageFormat> -->
<!-- <GenerateRuntimeConfigurationFiles>false</GenerateRuntimeConfigurationFiles> -->
Expand Down
Loading
Loading