[browser] rename WasmTestOnChrome - #101140
Merged
Merged
Conversation
ghost
added
the 
Contributor
|
Tagging subscribers to this area: @directhex |
This was referenced Apr 17, 2024
pavelsavara
force-pushed
the
WasmTestOnChrome
branch
from
April 17, 2024 09:10
d1108d8 to
1f11fed
Compare
pavelsavara
marked this pull request as ready for review
April 17, 2024 11:05
pavelsavara
requested review from
akoeplinger,
ilonatommy,
lewing,
maraf and
thaystg
as code owners
April 17, 2024 11:05
ilonatommy
reviewed
Apr 17, 2024
maraf
reviewed
Apr 17, 2024
Co-authored-by: Marek Fišera <mara@neptuo.com>
# Conflicts: # eng/testing/tests.browser.targets # src/libraries/sendtohelix-browser.targets # src/mono/wasm/Wasm.Build.Tests/Common/EnvironmentVariables.cs # src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj
This was referenced Apr 17, 2024
This was referenced Apr 17, 2024
Member
Author
|
/ba-g CI failures are known |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Co-authored-by: Marek Fišera <mara@neptuo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WasmTestOnBrowser->WasmTestOnChromenormal->WasmTestOnWasmtimeBROWSER_PATH_FOR_TESTS->CHROME_PATH_FOR_TESTSorFIREFOX_PATH_FOR_TESTS_WasmBrowserPathForTests->_WasmChromePathForTestsor_WasmFirefoxPathForTestsWasmRunnerAOTTemplate.shand move_buildAOTFunc()toWasmRunnerTemplate.shWasiRunnerAOTTemplate.shand move_buildAOTFunc()toWasiRunnerTemplate.sh$(TestArchiveRoot)chromeonly$(TestArchiveRoot)wasmtimeonlyChromeVersions.props->BrowserVersions.props