Skip to content

Add more logging to HTTP3 and QUIC code - #101449

Merged
rzikm merged 7 commits into
dotnet:mainfrom
rzikm:quic-extra-logging
Apr 24, 2024
Merged

Add more logging to HTTP3 and QUIC code#101449
rzikm merged 7 commits into
dotnet:mainfrom
rzikm:quic-extra-logging

Conversation

@rzikm

@rzikm rzikm commented Apr 23, 2024

Copy link
Copy Markdown
Member

This PR adds some tracing I found helpful when investigating recent test failures.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP ManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Comment thread src/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Comment thread src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs Outdated

@CarnaViire CarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm

rzikm commented Apr 24, 2024

Copy link
Copy Markdown
Member Author

Test failures are unrelated

matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
* Add more logging to QuicConnection and QuicStream

* Fix ptr format

* wip

* Add more http3 logging

* fixup! Add more http3 logging

* Code review feedback
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
* Add more logging to QuicConnection and QuicStream

* Fix ptr format

* wip

* Add more http3 logging

* fixup! Add more http3 logging

* Code review feedback
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Add more logging to QuicConnection and QuicStream

* Fix ptr format

* wip

* Add more http3 logging

* fixup! Add more http3 logging

* Code review feedback
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

4 participants