Allow preinitializing `EventSource` by MichalStrehovsky �� Pull Request #101573 · dotnet/runtime

MichalStrehovsky · 2024-04-25T21:23:46Z

Contributes to #79204.

We currently don't preinitialize any event sources because they have a finalizer. This is a bit of a problem for places like this:

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs

Lines 229 to 232 in 5c01ed2

    
           if (TplEventSource.Log.IsEnabled()) 
        
           { 
        
               TplEventSource.Log.TraceOperationBegin(box.Id, "Async: " + stateMachine.GetType().Name, 0); 
        
           }

. We know IsSupported is false so we eliminate the branch, but we still need a cctor check because we access a static (the Log field). The cctor check in a generic method that is instantiated many many many times becomes a death by a thousand papercuts.

Saves 0.7% in size on the stage2 app with EventSource disabled.

Cc @dotnet/ilc-contrib

We currently don't preinitialize any event sources because they have a finalizer. This is a bit of a problem for places like this: https://github.com/dotnet/runtime/blob/5c01ed22b7468a2bee13b498855dcfcc5ae4da50/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs#L229-L232. We know `IsSupported` is false so we eliminate the branch, but we still need a cctor check because we access a static. The cctor check in a generic method that is instantiated many many many times becomes a death by a thousand papercuts. Saves 0.7% in size on the stage2 app with EventSource disabled.

dotnet-policy-service · 2024-04-25T21:24:06Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

jkotas

Thanks!

We currently don't preinitialize any event sources because they have a finalizer. This is a bit of a problem for places like this: https://github.com/dotnet/runtime/blob/5c01ed22b7468a2bee13b498855dcfcc5ae4da50/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs#L229-L232. We know `IsSupported` is false so we eliminate the branch, but we still need a cctor check because we access a static. The cctor check in a generic method that is instantiated many many many times becomes a death by a thousand papercuts. Saves 0.7% in size on the stage2 app with EventSource disabled.

MichalStrehovsky added the area-NativeAOT-coreclr label Apr 25, 2024

dotnet-policy-service Bot assigned MichalStrehovsky Apr 25, 2024

jkotas approved these changes Apr 25, 2024

View reviewed changes

github-actions Bot mentioned this pull request Apr 25, 2024

101573 MichalStrehovsky/rt-sz#13

Closed

MichalStrehovsky merged commit 0f508f2 into dotnet:main Apr 26, 2024

MichalStrehovsky deleted the evtsrcfin branch April 26, 2024 12:58

github-actions Bot locked and limited conversation to collaborators May 27, 2024

Navigation Menu

Uh oh!

Allow preinitializing `EventSource` - #101573

Allow preinitializing `EventSource`#101573
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:evtsrcfin

MichalStrehovsky commented Apr 25, 2024

dotnet-policy-service Bot commented Apr 25, 2024

jkotas left a comment

Labels

2 participants

	if (TplEventSource.Log.IsEnabled())
	{
	TplEventSource.Log.TraceOperationBegin(box.Id, "Async: " + stateMachine.GetType().Name, 0);
	}