Skip to content

[wasm] Remove runtimeconfig.template.json from templates and provide it by default - #102818

Merged
maraf merged 5 commits into
dotnet:mainfrom
maraf:WasmAppHostDefaults
Jun 4, 2024
Merged

[wasm] Remove runtimeconfig.template.json from templates and provide it by default#102818
maraf merged 5 commits into
dotnet:mainfrom
maraf:WasmAppHostDefaults

Conversation

@maraf

@maraf maraf commented May 29, 2024

Copy link
Copy Markdown
Member
  • Remove runtimeconfig.template.json from browser template.
  • Remove runtimeconfig.template.json from wasi template.
  • Provide a default user runtime config if non is specified by the user.

Fixes #95345

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels May 29, 2024
@maraf maraf added this to the 9.0.0 milestone May 29, 2024
@maraf maraf self-assigned this May 29, 2024
@maraf maraf changed the title [wasm] Omit runtimeconfig.template.json in template and provide it by default May 29, 2024
@maraf
maraf marked this pull request as ready for review May 30, 2024 19:30
@maraf
maraf requested a review from radekdoulik May 31, 2024 08:31
@akoeplinger

Copy link
Copy Markdown
Member

Unrelated to this change but for mobile we created a special binary format of runtimeconfig.json so we don't need to parse JSON at runtime startup, I assume we don't use that on wasm?

@maraf

maraf commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

Unrelated to this change but for mobile we created a special binary format of runtimeconfig.json so we don't need to parse JSON at runtime startup, I assume we don't use that on wasm?

We do, partially. We use it in former Wasm SDK now used to build runtime tests (WasmAppBuilder). Blazor (and the refactored new Wasm SDK) doesn't need anything from runtimeconfig and so they have it turned off.

@maraf
maraf merged commit db5e98d into dotnet:main Jun 4, 2024
@maraf
maraf deleted the WasmAppHostDefaults branch June 4, 2024 15:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

2 participants