Delete -fms-extensions from coreclr native build - #102834
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @hoyosjs |
am11
force-pushed
the
feature/std=c++11+no-ms-extensions
branch
from
May 30, 2024 06:59
27819e3 to
b621127
Compare
am11
marked this pull request as ready for review
May 30, 2024 07:10
am11
requested review from
a team,
AaronRobinsonMSFT,
MichalStrehovsky and
janvorli
as code owners
May 30, 2024 07:10
huoyaoyuan
reviewed
May 30, 2024
janvorli
reviewed
May 30, 2024
|
|
||
| inline void RetailBreak() | ||
| { | ||
| #ifdef TARGET_X86 |
Member
There was a problem hiding this comment.
I wonder why it was defined differently for x86. @jkotas do you have any idea?
Member
There was a problem hiding this comment.
Historically, inline int 3 gave a better experience under the debugger - the debugger stopped in your code, not inside a Windows DebugBreak API.
janvorli
reviewed
May 30, 2024
jkotas
reviewed
May 30, 2024
am11
force-pushed
the
feature/std=c++11+no-ms-extensions
branch
from
May 30, 2024 16:22
700888f to
78b29e9
Compare
jkotas
reviewed
May 30, 2024
This was referenced Jun 13, 2024
Open
Member
Author
|
OSX failure is infra issue (tests are passing but helix job is unable to exit cleanly): rest of failures are known issues (per Build Analysis). @jkotas, PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For stdcpp conformance, remove the remaining special extensions.
__asm {}syntax with__asm ("")src/nativewhich helped validating the rest of the changes on the platform.