Skip to content

Support IAlternateEqualityComparer with FrozenDictionary/Set - #103191

Merged
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:frozenalternatecomparer
Jun 12, 2024
Merged

Support IAlternateEqualityComparer with FrozenDictionary/Set#103191
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:frozenalternatecomparer

Conversation

@stephentoub

@stephentoub stephentoub commented Jun 8, 2024

Copy link
Copy Markdown
Member

Closes #27229

Per the discussion in #27229 (comment), for string keys, this only supports an alternate key of ReadOnlySpan<char>... other alternate key types will fail to return a lookup. That's a compromise to not supporting lookups at all.

@ghost

ghost commented Jun 8, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
1 similar comment
@ghost

ghost commented Jun 8, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
Comment thread src/libraries/System.Collections.Immutable/src/Interfaces.cd
Comment thread src/libraries/System.Collections.Immutable/src/Resources/Strings.resx Outdated
@stephentoub
stephentoub merged commit 1ddfd18 into dotnet:main Jun 12, 2024
@stephentoub
stephentoub deleted the frozenalternatecomparer branch June 12, 2024 19:25
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.