Skip to content

Add Regex.EnumerateSplits - #103307

Merged
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:regexenumeratesplits
Jun 12, 2024
Merged

Add Regex.EnumerateSplits#103307
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:regexenumeratesplits

Conversation

@stephentoub

@stephentoub stephentoub commented Jun 11, 2024

Copy link
Copy Markdown
Member

Closes #100369
@ghost

ghost commented Jun 11, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost

ghost commented Jun 11, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
This was referenced Jun 12, 2024
Closed
Closed
Open
Closed
Closed
joperezr
joperezr approved these changes Jun 12, 2024
View reviewed changes

@joperezr joperezr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions but looks great. Thanks Steve!
Comment thread ...s/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.EnumerateSplits.cs
Comment thread ...ibraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.EnumerateSplits.Tests.cs
@stephentoub
stephentoub merged commit a08fe0f into dotnet:main Jun 12, 2024
@stephentoub
stephentoub deleted the regexenumeratesplits branch June 12, 2024 16:43
@colejohnson66

colejohnson66 commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

I know this is already merged, but shouldn't startat be startAt?
@stephentoub

stephentoub commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

I know this is already merged, but shouldn't startat be startAt?

If we were starting from scratch, yes, but this is how all the other regex methods spell it, e.g. https://learn.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.regex.match?view=net-8.0#system-text-regularexpressions-regex-match(system-string-system-int32), so we're staying consistent with that.
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.