Skip to content

Add JsonMarshal.GetRawUtf8Value - #104595

Merged
eiriktsarpalis merged 5 commits into
dotnet:mainfrom
eiriktsarpalis:jsonmarshal-jsonelement
Jul 10, 2024
Merged

Add JsonMarshal.GetRawUtf8Value#104595
eiriktsarpalis merged 5 commits into
dotnet:mainfrom
eiriktsarpalis:jsonmarshal-jsonelement

Conversation

@eiriktsarpalis

@eiriktsarpalis eiriktsarpalis commented Jul 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fix #77666. Pending API approval.

cc @annelo-msft @KrzysztofCwalina
@ghost ghost added the area-System.Text.Json label Jul 9, 2024
@eiriktsarpalis eiriktsarpalis self-assigned this Jul 9, 2024
@ghost

ghost commented Jul 9, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Jul 9, 2024
@dotnet dotnet deleted a comment Jul 9, 2024
stephentoub
stephentoub reviewed Jul 9, 2024
View reviewed changes
Comment thread src/libraries/System.Text.Json/src/System/Runtime/InteropServices/JsonMarshal.cs Outdated
This was referenced Jul 9, 2024
Open
Closed
@eiriktsarpalis eiriktsarpalis changed the title Add JsonMarshal.TryGetRawValue Jul 9, 2024
@eiriktsarpalis

eiriktsarpalis commented Jul 9, 2024

Copy link
Copy Markdown
Member Author

Updated to the approved API shape.
This was referenced Jul 9, 2024
Closed
Closed
Closed
stephentoub
stephentoub approved these changes Jul 10, 2024
View reviewed changes

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the test naming comment, LGTM
This was referenced Jul 10, 2024
Open
Closed
@eiriktsarpalis
eiriktsarpalis merged commit 635f9af into dotnet:main Jul 10, 2024
@eiriktsarpalis
eiriktsarpalis deleted the jsonmarshal-jsonelement branch July 10, 2024 22:56
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@matouskozak
Revert "Add JsonMarshal.GetRawUtf8Value (dotnet#104595)"
dfd5dfb 
This reverts commit 635f9af.
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.