Skip to content

[API Implementation]: Expose CookieException constructors - #109026

Merged
MihaZupan merged 4 commits into
dotnet:mainfrom
deeprobin:issue-95965
Oct 22, 2024
Merged

[API Implementation]: Expose CookieException constructors#109026
MihaZupan merged 4 commits into
dotnet:mainfrom
deeprobin:issue-95965

Conversation

@deeprobin

Copy link
Copy Markdown
Contributor

This PR implements and fixes #95965.

  • Expose constructors
  • Add doc comments
  • Add new public API to ref assembly
  • Add tests for passing null and non-null parameters to the ctors

Potentially breaking change if somebody does reflection hacks:

  • Rename the previous internal parameter inner to innerException as defined in the approved API scheme.

Added APIs

namespace System.Net;

public partial class CookieException
{
    public CookieException(string? message);
    public CookieException(string? message, Exception? innerException);
 }
@ghost

ghost commented Oct 18, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
1 similar comment
@ghost

ghost commented Oct 18, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Oct 18, 2024
@deeprobin
deeprobin marked this pull request as ready for review October 18, 2024 21:25

@MihaZupan MihaZupan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment thread src/libraries/System.Net.Primitives/src/System/Net/CookieException.cs Outdated
Comment thread src/libraries/System.Net.Primitives/src/System/Net/CookieException.cs Outdated
Comment thread src/libraries/System.Net.Primitives/src/System/Net/CookieException.cs Outdated
deeprobin and others added 2 commits October 21, 2024 20:15
Comment thread src/libraries/System.Net.Primitives/tests/UnitTests/CookieExceptionTest.cs Outdated
@MihaZupan
MihaZupan merged commit 670401f into dotnet:main Oct 22, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

4 participants