Skip to content

adding GetOtherNotificationFlags cDAC API - #117616

Merged
rcj1 merged 6 commits into
dotnet:mainfrom
rcj1:GetOtherNotificationFlags
Jul 22, 2025
Merged

adding GetOtherNotificationFlags cDAC API#117616
rcj1 merged 6 commits into
dotnet:mainfrom
rcj1:GetOtherNotificationFlags

Conversation

@rcj1

@rcj1 rcj1 commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new cDAC API GetOtherNotificationFlags to read notification flags from the target process, updates the global constants to include DacNotificationFlags, and registers this global in the native descriptor.

  • Implements IXCLRDataProcess.GetOtherNotificationFlags with exception handling and debug cross-checks.
  • Adds DacNotificationFlags to managed contract constants.
  • Registers DacNotificationFlags in datadescriptor.h.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs Added new GetOtherNotificationFlags implementation
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Constants.cs Added DacNotificationFlags constant
src/coreclr/debug/runtimeinfo/datadescriptor.h Registered DacNotificationFlags with CDAC_GLOBAL_POINTER
Comments suppressed due to low confidence (2)

src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs:213

  • The new GetOtherNotificationFlags API lacks unit tests. Consider adding tests to cover successful reads, exception paths, and the debug-mode comparison against the legacy implementation.
    int IXCLRDataProcess.GetOtherNotificationFlags(uint* flags)

src/coreclr/debug/runtimeinfo/datadescriptor.h:971

  • [nitpick] This line is missing the leading space for alignment with the surrounding CDAC_GLOBAL_POINTER entries; adding it will keep the code formatting consistent.
CDAC_GLOBAL_POINTER(DacNotificationFlags, &::g_dacNotificationFlags)
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Comment thread src/coreclr/debug/runtimeinfo/datadescriptor.h
@rcj1

rcj1 commented Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

/ba-g infrastructure timeouts

@rcj1
rcj1 merged commit b131b6d into dotnet:main Jul 22, 2025
90 of 98 checks passed
@rcj1
rcj1 deleted the GetOtherNotificationFlags branch July 22, 2025 15:37
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.