Fix Array::GetDirectPointerToNonObjectElements DAC regression - #129271
Merged
tommcdon merged 2 commits intoJun 12, 2026
Conversation
In DAC mode, m_Array yields a host address, but PTR_KIND requires a target address. GetDataPtr() computes the correct target address via dac_cast<PTR_BYTE>(this) + offset. This was broken by PR dotnet#128961 which changed from GetDataPtr() to m_Array, breaking debugger inspection of exception stack traces, ConditionalWeakTable lookups, and stack frame helper arrays in DAC mode. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a DAC (data access / debugger) regression in CoreCLR’s Array<KIND>::GetDirectPointerToNonObjectElements() by ensuring it returns a target address (as required by DPTR/PTR_KIND) rather than a host address derived from the m_Array field.
Changes:
- Update
Array<KIND>::GetDirectPointerToNonObjectElements()to returnPTR_KIND(GetDataPtr())instead ofPTR_KIND(m_Array)so DAC computes the correct target address for array data. - Restore behavior compatible with DAC-based inspection scenarios that rely on correct primitive-array data pointers.
jkotas
reviewed
Jun 11, 2026
jkotas
reviewed
Jun 11, 2026
This was referenced Jun 11, 2026
Open
Use dac_cast<PTR_KIND>(PTR_HOST_MEMBER_TADDR(Array, this, m_Array)) instead of PTR_KIND(GetDataPtr()) to correctly compute the target address in DAC builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis
pushed a commit
that referenced
this pull request
Jul 15, 2026
In DAC mode, m_Array yields a host address, but PTR_KIND requires a target address. GetDataPtr() computes the correct target address via dac_cast<PTR_BYTE>(this) + offset. This was broken by PR #128961 which changed from GetDataPtr() to m_Array, breaking debugger inspection of exception stack traces, ConditionalWeakTable lookups, and stack frame helper arrays in DAC mode. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DAC mode, m_Array yields a host address, but PTR_KIND requires a target address. GetDataPtr() computes the correct target address via dac_cast<PTR_BYTE>(this) + offset.
This was broken by PR #128961 which changed from GetDataPtr() to m_Array, breaking debugger inspection of exception stack traces, ConditionalWeakTable lookups, and stack frame helper arrays in DAC mode.