Closed
Fix FEATURE_DISTRO_AGNOSTIC_SSL guards in ECC import/export#129332
Conversation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jkotas
June 12, 2026 14:58
View session
jkotas
marked this pull request as ready for review
June 12, 2026 15:29
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Member
|
This is fixing build break in non-portable builds https://dev.azure.com/dnceng-public/public/_build/results?buildId=1460883&view=logs&j=2eda3965-9146-55d1-4226-c3d3f8432d8f&t=27bbe0a6-6c05-550a-bc6f-305cf5eac8aa&l=1044 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes native crypto (OpenSSL) compilation under non-portable builds with -Wundef by avoiding #if FEATURE_DISTRO_AGNOSTIC_SSL when the macro may be undefined, aligning these guards with the existing #ifdef FEATURE_DISTRO_AGNOSTIC_SSL pattern used elsewhere in the same component.
Changes:
- Replaced three
#if FEATURE_DISTRO_AGNOSTIC_SSLdirectives with#ifdef FEATURE_DISTRO_AGNOSTIC_SSLin ECC import/export code paths. - Prevented
-Wundef(and-Werror-promoted) build failures whenFEATURE_DISTRO_AGNOSTIC_SSLis not defined.
Member
|
Duplicate of #129330 |
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the native crypto build break caused by
#if FEATURE_DISTRO_AGNOSTIC_SSLin non-portable builds, where the macro is not defined and-Wundefturns the check into a hard error.