Better generic cycle detection in MethodEntryGenericLookupResult - #129730
Merged
Conversation
We missed a spot. Fixes dotnet#129697
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts NativeAOT generic-lookup handling to perform generic cycle detection for method-entry (function pointer) lookups consistently, instead of only doing so on the non-concrete/canonical shadow-path.
Changes:
- Move
DetectGenericCycles(dictionary.Context, instantiatedMethod)to run unconditionally inMethodEntryGenericLookupResult.GetTarget. - Remove the now-redundant cycle detection call from the canonical/non-abstract shadow-method branch.
jkotas
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed a spot.
Fixes #129697
Test is in #128702.