Add DacMode-based SOS test legs to runtime-diagnostics pipeline - #129859
Merged
Conversation
Replace the useCdac/noFallback booleans with a single dacMode parameter and add a 4th SOS leg. The shared windows_x64 build now uploads the freshly built cDAC (mscordaccore_universal) as a separate artifact for the cdac leg to consume. Legs (windows_x64 Release, testInterpreter): cDAC dacMode cdac standalone cDAC via SOS (downloads+overlays the built cDAC) cDAC_fallback dacMode cdacfallback in-box DAC hosts cDAC, with fallback cDAC_verify dacMode cdacverify in-box DAC hosts cDAC, no fallback (verifies) DAC dacMode dac legacy DAC only Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the runtime-diagnostics Azure DevOps pipeline SOS test legs to use a single dacMode selector (instead of useCdac/noFallback), adds an additional SOS leg, and wires up publishing/downloading the freshly-built standalone cDAC so the cdac leg can exercise the runtime-under-test’s own mscordaccore_universal.
Changes:
- Replace
useCdac/noFallbackbooleans with a singledacModestring parameter through the SOS leg templates. - Add a 4th SOS leg (
cDAC_verify) and adjust existing leg naming/modes (cDAC_fallback,DAC). - Publish the built
mscordaccore_universaloutput as a separate artifact and download it only for thedacMode: cdacleg.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/runtime-diagnostics.yml | Adds the 4th SOS leg, switches legs to dacMode, and uploads the built cDAC as a dedicated artifact. |
| eng/pipelines/diagnostics/sos-test-leg.yml | Replaces boolean toggles with dacMode and conditionally downloads the cDAC artifact for the cdac mode. |
| eng/pipelines/diagnostics/runtime-diag-job.yml | Maps dacMode to the corresponding -dacMode / -cdacPath arguments passed to the diagnostics build/test harness. |
max-charlamb
marked this pull request as ready for review
June 25, 2026 18:41
This was referenced Jun 26, 2026
Member
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hoyosjs
approved these changes
Jun 26, 2026
Member
Author
|
/ba-g cDAC pipeline Chang to sync with diagnostics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
useCdac/noFallbackbooleans in the SOS test legs with a singledacModeparameter and adds a 4th leg. The shared windows_x64 build now uploads the freshly built cDAC (mscordaccore_universal) as a separate artifact for thecdacleg to consume.SOS legs (windows_x64 Release,
testInterpreter):dacMode cdac-- standalone cDAC via SOS (downloads + overlays the built cDAC next to sos.dll)dacMode cdacfallback-- in-box DAC hosts cDAC, with fallbackdacMode cdacverify-- in-box DAC hosts cDAC, no fallback (verifies)dacMode dac-- legacy DAC onlyDepends on the
DacModesupport added in dotnet/diagnostics#5901. To exercise it before that merges, queueruntime-diagnosticswithdiagnosticsBranchpointing at the diagnostics PR's merge ref.Sample run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1481626&view=logs&j=d359ac0d-403b-5f4f-9a78-93671d33ea9d