Disable Runtime_129681 CrossGen2 testing - #132126
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR GC regression test project Runtime_129681 to opt out of CrossGen2/R2R compilation in the test harness, allowing the regression to continue running in R2R CI legs without failing during the ahead-of-time compilation step.
Changes:
- Disable CrossGen2 for
Runtime_129681by setting<CrossGenTest>false</CrossGenTest>. - Add a brief comment in the project file documenting the reason and linking to the tracking issue.
kkokosa
marked this pull request as ready for review
August 11, 2026 11:28
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Aug 11, 2026
jkotas
approved these changes
Aug 12, 2026
jkoritzinsky
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime_129681configures a 64 MiB GC heap hard limit, but CrossGen2 reserves 6 GiB for regions. Opt the test out of CrossGen2 so R2R jobs still execute the regression without failing during ahead-of-time compilation.Fixes #132062
Fixes #132037
Validation
build.cmd clr+libs -lc release -rc checked: succeeded with 0 warnings and 0 errors.src\tests\build.cmd -Test GC\Regressions\Github\Runtime_129681\Runtime_129681.csproj x64 checked -Priority 1: succeeded with 0 warnings and 0 errors.RunCrossGen2=1: the test passed (Expected: 100,Actual: 100), the script contained no Crossgen2 compiler orIL-CG2compilation commands, and noIL-CG2directory was created.Replacing
DOTNET_GCStress=0xCwithDOTNET_gcConcurrent=0could be investigated separately because this regression only needs concurrent GC disabled. That may address the plain macOS startup failure in #132045; this PR does not claim to fix it.Note
This PR description was generated with GitHub Copilot.