Use integer division trick to get exact base64 length - #50549
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
EgorBo
reviewed
Apr 1, 2021
jkotas
reviewed
Apr 1, 2021
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
stephentoub
approved these changes
Apr 1, 2021
|
Tagging subscribers to this area: @tannergooding Issue Details...and avoid (explicit) modulo operation. Produces less machine code.
|
jkotas
approved these changes
May 3, 2021
Member
|
Thank you! |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and avoid (explicit) modulo operation.
Produces less machine code.