Skip to content

PUTARG_STK/x86: mark push [mem] candidates reg optional - #68641

Merged
kunalspathak merged 1 commit into
dotnet:mainfrom
SingleAccretion:PutargStk-RegOptional
May 9, 2022
Merged

PUTARG_STK/x86: mark push [mem] candidates reg optional#68641
kunalspathak merged 1 commit into
dotnet:mainfrom
SingleAccretion:PutargStk-RegOptional

Conversation

@SingleAccretion

@SingleAccretion SingleAccretion commented Apr 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

In #67400 I enabled containment for PUTARG_STK sources coming from memory on x86. This change completes that change by also enabling the "reg optional" setting, for yet more CQ:

benchmarks.run.windows.x86:      -9.6K
coreclr_tests.pmi.windows.x86:   -37K
libraries.crossgen2.windows.x86: -81K
libraries.pmi.windows.x86:       -77K
libraries_tests.pmi.windows.x86: -114K

(All regressions are due to different allocation)
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 28, 2022
@ghost

ghost commented Apr 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

In #67400 I enabled containment for PUTARG_STK sources coming from memory on x86. This change completes that change by also enabling the "reg optional" setting, for yet more CQ gains:

benchmarks.run.windows.x86: -9.6K
Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -
@SingleAccretion
SingleAccretion marked this pull request as ready for review April 28, 2022 14:26
@SingleAccretion

SingleAccretion commented Apr 28, 2022

Copy link
Copy Markdown
Contributor Author

x86 SPMI diffs timed out, OSX failure is #68654.

@dotnet/jit-contrib
@SingleAccretion
SingleAccretion force-pushed the PutargStk-RegOptional branch from b7ae267 to e377a4f Compare May 2, 2022 13:12
@SingleAccretion
SingleAccretion force-pushed the PutargStk-RegOptional branch from e377a4f to 28bb507 Compare May 8, 2022 14:37
@AndyAyersMS
AndyAyersMS requested a review from kunalspathak May 8, 2022 16:07
kunalspathak
kunalspathak approved these changes May 9, 2022
View reviewed changes

@kunalspathak kunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak merged commit 95952a6 into dotnet:main May 9, 2022
@SingleAccretion
SingleAccretion deleted the PutargStk-RegOptional branch May 9, 2022 19:07
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Jun 3, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

2 participants

@SingleAccretion @kunalspathak