Skip to content

Disable failing MsQuic tests on Windows - #69798

Merged
rzikm merged 2 commits into
dotnet:mainfrom
rzikm:69792-disable-quic-cert-tests-on-win-server
May 26, 2022
Merged

Disable failing MsQuic tests on Windows#69798
rzikm merged 2 commits into
dotnet:mainfrom
rzikm:69792-disable-quic-cert-tests-on-win-server

Conversation

@rzikm

@rzikm rzikm commented May 25, 2022

Copy link
Copy Markdown
Member

Contributes to #69792.

This PR disables newly failing tests. The failures seem to be confined to Windows 2022 Server.

@ghost ghost assigned rzikm May 25, 2022
@ghost ghost added the area-System.Net.Quic label May 25, 2022
@ghost

ghost commented May 25, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #69792.

This PR disables newly failing tests. The failures seem to be confined to Windows 2022 Server.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net.Quic

Milestone: -
@rzikm
rzikm requested a review from wfurt May 25, 2022 15:00

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt

wfurt commented May 25, 2022

Copy link
Copy Markdown
Member

btw there are still Quic failures but it seems unrelated to this change.

   System.Net.Quic.Functional.Tests: [Long Running Test] 'System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate', Elapsed: 00:14:07
['System.Net.Quic.Functional.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]
@rzikm
rzikm merged commit 5d3288d into dotnet:main May 26, 2022
@rzikm

rzikm commented May 26, 2022

Copy link
Copy Markdown
Member Author

btw there are still Quic failures but it seems unrelated to this change.

   System.Net.Quic.Functional.Tests: [Long Running Test] 'System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate', Elapsed: 00:14:07
['System.Net.Quic.Functional.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

I noticed, I will deal with that separately to unblock CI asap (this one is nondeterministic),

@joperezr

Copy link
Copy Markdown
Member

This is failing PR builds in 7.0-preview5 branch since they haven't been disabled there. Should this change make it there as well?

@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

4 participants