Skip to content

Utilize ProtocolException for HTTP/2 in HttpStress - #72034

Merged
antonfirsov merged 4 commits into
dotnet:mainfrom
antonfirsov:fix-HttpStress-http2-ProtocolException
Jul 18, 2022
Merged

Utilize ProtocolException for HTTP/2 in HttpStress#72034
antonfirsov merged 4 commits into
dotnet:mainfrom
antonfirsov:fix-HttpStress-http2-ProtocolException

Conversation

@antonfirsov

Copy link
Copy Markdown
Contributor

Fixes #72015

@antonfirsov
antonfirsov requested a review from a team July 12, 2022 16:59
@ghost ghost assigned antonfirsov Jul 12, 2022
@ghost

ghost commented Jul 12, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #72015

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -
}
}

// TODO: change when HttpProtocolException gets implemented for HTTP/3

@antonfirsov antonfirsov Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rzikm shall we address this:

  1. As part of Implement new QuicException proposal #71432
  2. In this PR after merging Implement new QuicException proposal #71432
  3. In a completely separate PR
    ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will address it in #72095

@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm rzikm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
@antonfirsov
antonfirsov merged commit 32aa0e1 into dotnet:main Jul 18, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants