Skip to content

Support targeting iOS platforms with ILCompiler - #81476

Merged
ivanpovazan merged 6 commits into
dotnet:mainfrom
ivanpovazan:ilc-ios
Feb 3, 2023
Merged

Support targeting iOS platforms with ILCompiler#81476
ivanpovazan merged 6 commits into
dotnet:mainfrom
ivanpovazan:ilc-ios

Conversation

@ivanpovazan

@ivanpovazan ivanpovazan commented Feb 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This PR enables ILCompiler to target iOS and iOSSimulator platforms.

It has been tested against a private branch which includes changes that enable building NativeAOT for iOS platforms.

/cc: @dotnet/ilc-contrib
@ivanpovazan ivanpovazan added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 1, 2023
@ghost ghost assigned ivanpovazan Feb 1, 2023
@ghost

ghost commented Feb 1, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a work-in-progress PR of enabling ILCompiler to target iOS and iOSSimulator platforms.

It is being tested against a private branch which includes changes that enable building NativeAOT for iOS platforms.

/cc: https://github.com/orgs/dotnet/teams/ilc-contrib

Author: ivanpovazan
Assignees: -
Labels:

NO-MERGE, area-NativeAOT-coreclr
Milestone: -
jkotas
jkotas reviewed Feb 1, 2023
View reviewed changes
Comment thread src/coreclr/tools/Common/Compiler/DependencyAnalysis/Target_X64/TargetRegisterMap.cs Outdated
akoeplinger
akoeplinger reviewed Feb 1, 2023
View reviewed changes
Comment thread src/coreclr/tools/Common/CommandLineHelpers.cs Outdated
ivanpovazan
ivanpovazan commented Feb 1, 2023
View reviewed changes
Comment thread src/coreclr/tools/aot/ILCompiler.Diagnostics/PerfMapWriter.cs Outdated
@filipnavara

filipnavara commented Feb 1, 2023

Copy link
Copy Markdown
Member

Btw, this line will likely need to be updated once this lands.
marek-safar
marek-safar reviewed Feb 2, 2023
View reviewed changes
Comment thread src/coreclr/tools/Common/CommandLineHelpers.cs Outdated
@SamMonoRT
SamMonoRT requested a review from rolfbjarne February 2, 2023 14:37
jkotas
jkotas approved these changes Feb 2, 2023
View reviewed changes

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a reason why you have marked it as NO-MERGE?
@ivanpovazan

ivanpovazan commented Feb 2, 2023

Copy link
Copy Markdown
Member Author

LGTM. Is there a reason why you have marked it as NO-MERGE?

@jkotas, I thought of waiting for the dependent issue (from the PR's description) to be closed first.
@jkotas

jkotas commented Feb 2, 2023

Copy link
Copy Markdown
Member

@jkotas, I thought of waiting for the dependent issue (from the PR's description) to be closed first.

I do not think we need to wait for the other issue to be closed. This PR looks good to me as-is.
@filipnavara

filipnavara commented Feb 2, 2023

Copy link
Copy Markdown
Member

I do not think we need to wait for the other issue to be closed

+1. This unblocks some work in other repositories.
@ivanpovazan ivanpovazan removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 2, 2023
@ivanpovazan
ivanpovazan marked this pull request as ready for review February 2, 2023 16:10
@ivanpovazan ivanpovazan changed the title WIP: Support targeting iOS platforms with ILCompiler Feb 2, 2023
@MichalStrehovsky MichalStrehovsky mentioned this pull request Feb 2, 2023
Merged
@ivanpovazan
ivanpovazan merged commit 47071da into dotnet:main Feb 3, 2023
@ivanpovazan
ivanpovazan deleted the ilc-ios branch February 3, 2023 15:13
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.