Skip to content

[nativeaot] Build host bits when targeting iOS platforms with Native AOT - #87985

Merged
kotlarmilos merged 1 commit into
dotnet:mainfrom
kotlarmilos:feature/nativeaot-ios-host-build
Jun 26, 2023
Merged

[nativeaot] Build host bits when targeting iOS platforms with Native AOT#87985
kotlarmilos merged 1 commit into
dotnet:mainfrom
kotlarmilos:feature/nativeaot-ios-host-build

Conversation

@kotlarmilos

Copy link
Copy Markdown
Member

This PR aims to simplify the build process for Native AOT when targeting iOS. Currently, two separate builds are necessary for iOS-like platforms. The first build is for the host

./build.sh clr+clr.aot

while the second build is for the target platform.

./build.sh clr.nativeaotruntime+nativeaotlibs+lib -os ios

Idea is to build the host each time the clr.nativeaotruntime is built for iOS-like platforms. This PR simplifies the CI builds by eliminating the need for additional steps.

Fixes #87764

@ghost

ghost commented Jun 23, 2023

Copy link
Copy Markdown

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR aims to simplify the build process for Native AOT when targeting iOS. Currently, two separate builds are necessary for iOS-like platforms. The first build is for the host

./build.sh clr+clr.aot

while the second build is for the target platform.

./build.sh clr.nativeaotruntime+nativeaotlibs+lib -os ios

Idea is to build the host each time the clr.nativeaotruntime is built for iOS-like platforms. This PR simplifies the CI builds by eliminating the need for additional steps.

Fixes #87764

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

os-ios, area-NativeAOT-coreclr

Milestone: 8.0.0
@steveisok
steveisok self-requested a review June 26, 2023 18:31
@kotlarmilos

Copy link
Copy Markdown
Member Author

The failures are known and shouldn't be related.

@kotlarmilos
kotlarmilos merged commit bfa9b97 into dotnet:main Jun 26, 2023
@steveisok

Copy link
Copy Markdown
Member

@kotlarmilos I think this might have caused our official build to break. Can you please investigate?

@kotlarmilos

kotlarmilos commented Jun 27, 2023

Copy link
Copy Markdown
Member Author

That's right, the "cross" build scenario is failing. The PR #88079 should fix the issue by ensuring that a host architecture is used during the host build.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants