Remove some unnecessary indirection to DiagnosticServerAdapter/EventPipeAdapter in nativeaot - #90132
Merged
Merged
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis removes
|
elinor-fung
force-pushed
the
removeAdapterLayer
branch
2 times, most recently
from
August 8, 2023 16:34
8b36c17 to
3c76de2
Compare
…ipeAdapter in nativeaot
elinor-fung
force-pushed
the
removeAdapterLayer
branch
from
August 8, 2023 19:24
3c76de2 to
9102e1a
Compare
This was referenced Aug 9, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
DiagnosticServerAdapterand a bunch of functions inEventPipeAdapterin nativeaot. The functions left inEventPipeAdapterare currently used in the would-be-generated code indotnetruntime.cpp. I just left them for now - they can go away when we switch to the script generation. The changes to the header includes were fallout from removing unnecessary includes fromeventpipeadapter.hand others.