Skip to content

Don't put any modifiers after ref - #94875

Merged
jtschuster merged 3 commits into
dotnet:mainfrom
jtschuster:RefStructLibraryImport
Nov 20, 2023
Merged

Don't put any modifiers after ref#94875
jtschuster merged 3 commits into
dotnet:mainfrom
jtschuster:RefStructLibraryImport

Conversation

@jtschuster

@jtschuster jtschuster commented Nov 16, 2023

Copy link
Copy Markdown
Member

Fixes #94840.

We need to make sure we don't add the unsafe modifier after the ref keyword. We'll insert at the min index of partial and ref keyword.
@ghost ghost assigned jtschuster Nov 16, 2023
@ghost

ghost commented Nov 16, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #94840.

We need to make sure we don't add the unsafe modifier after the ref keyword. We'll insert at the min index of partial and ref keyword.

Author: jtschuster
Assignees: -
Labels:

area-System.Runtime.InteropServices
Milestone: -
jtschuster and others added 2 commits November 16, 2023 13:06
@jtschuster @AaronRobinsonMSFT
Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…
d44dbad 
…erop.SourceGeneration/SyntaxExtensions.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@jtschuster
Revert tests and use full words for library name
ba17c83
@jtschuster jtschuster mentioned this pull request Nov 17, 2023
Closed
@jtschuster
jtschuster merged commit c38198d into dotnet:main Nov 20, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.