Skip to content

Forward minipal_get_length_utf16_to_utf8 and minipal_convert_utf16_to_utf8 from DAC - #97055

Merged
tommcdon merged 1 commit into
dotnet:mainfrom
tommcdon:dev/tommcdon/fix96747
Jan 17, 2024
Merged

Forward minipal_get_length_utf16_to_utf8 and minipal_convert_utf16_to_utf8 from DAC#97055
tommcdon merged 1 commit into
dotnet:mainfrom
tommcdon:dev/tommcdon/fix96747

Conversation

@tommcdon

@tommcdon tommcdon commented Jan 16, 2024

Copy link
Copy Markdown
Member

Fixes #96747
@tommcdon tommcdon added this to the 9.0.0 milestone Jan 16, 2024
@tommcdon
tommcdon requested a review from mikem8361 January 16, 2024 23:01
@tommcdon tommcdon self-assigned this Jan 16, 2024
@ghost

ghost commented Jan 16, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #96747

Author: tommcdon
Assignees: tommcdon
Labels:

area-Diagnostics-coreclr
Milestone: 9.0.0
@tommcdon

tommcdon commented Jan 17, 2024

Copy link
Copy Markdown
Member Author

Failures look unrelated to this PR and are similar to #96904
@build-analysis build-analysis Bot mentioned this pull request Jan 17, 2024
Closed
@tommcdon
tommcdon merged commit 1263107 into dotnet:main Jan 17, 2024
@huoyaoyuan

huoyaoyuan commented Jan 17, 2024

Copy link
Copy Markdown
Member

If we are going to use more minipal_utf8 functions, the utf8_to_utf16 counterparts will also need to be forwarded.
@build-analysis build-analysis Bot mentioned this pull request Jan 17, 2024
Closed
@tommcdon tommcdon mentioned this pull request Jan 19, 2024
Closed
tommcdon added a commit to tommcdon/runtime that referenced this pull request Jan 21, 2024
@tommcdon
Revert "Forward minipal_get_length_utf16_to_utf8 and minipal_convert_…
c83ce08 
…utf16_to_utf8 from DAC (dotnet#97055)"

This reverts commit 1263107.
@tommcdon tommcdon mentioned this pull request Jan 21, 2024
Merged
tommcdon added a commit that referenced this pull request Jan 21, 2024
@tommcdon
Revert pr#96099 (#97264)
b8114f9 
* Revert "Forward minipal_get_length_utf16_to_utf8 and minipal_convert_utf16_to_utf8 from DAC (#97055)"

This reverts commit 1263107.

* Revert "Cleanup some string operating functions (#96099)"

This reverts commit bc81c55.
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@tommcdon @tmds
Forward minipal_get_length_utf16_to_utf8 and minipal_convert_utf16_to…
80f1ed6 
…_utf8 from DAC (dotnet#97055)
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@tommcdon @tmds
Revert pr#96099 (dotnet#97264)
6ea4a37 
* Revert "Forward minipal_get_length_utf16_to_utf8 and minipal_convert_utf16_to_utf8 from DAC (dotnet#97055)"

This reverts commit 1263107.

* Revert "Cleanup some string operating functions (dotnet#96099)"

This reverts commit bc81c55.
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.