Remove RuntimeIdentifiers from Microsoft.NETCore.App.Crossgen2.sfxproj - #98956
Merged
Conversation
ghost
added
the
This was referenced Feb 27, 2024
akoeplinger
force-pushed
the
remove-crossgen-rid
branch
from
March 1, 2024 16:33
7b62d92 to
ea2459a
Compare
It shouldn't be needed according to dotnet#98948 (comment)
akoeplinger
force-pushed
the
remove-crossgen-rid
branch
from
March 4, 2024 10:41
ea2459a to
aa611a1
Compare
akoeplinger
marked this pull request as ready for review
March 4, 2024 14:48
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsIt shouldn't be needed according to #98948 (comment) Running a test official build in https://dev.azure.com/dnceng/internal/_build/results?buildId=2392869&view=results
|
Member
Author
|
I compared the MergedManifest.xml between this PR official build and one from main and there are no differences (except *.wixpack files which are not generated due to PostBuildSign being false on manual builds). |
ViktorHofer
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It shouldn't be needed according to #98948 (comment)
Running a test official build in https://dev.azure.com/dnceng/internal/_build/results?buildId=2392869&view=results